Repository navigation
Conversation
The smoke test reads GitHub anonymously. GitHub allows an address 60 anonymous requests an hour, and a hosted runner shares its address with other jobs. On macos-latest the step failed in both attempts of the 0.11.6 release run, the first one with a RateLimitExceededException. The build job needs every aot-pack job, so it was skipped and 0.11.6 did not reach nuget.org. The smoke target now passes --token when GITHUB_TOKEN is set, and the CI step sets it to the workflow token. A run without the variable stays anonymous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The AOT smoke test (
./build.sh smokeaot) now reads GitHub with a token whenGITHUB_TOKENis set, and theaot-packjob sets the variable to the workflow token. A run without the variable stays anonymous.Intention
The smoke test reads GitHub anonymously. GitHub allows an address 60 anonymous requests an hour, and a hosted runner shares its address with other jobs. On
macos-latestthe step failed in both attempts of the 0.11.6 release run, the first one withOctokit.RateLimitExceededException. Thebuildjob needs everyaot-packjob, so it was skipped and 0.11.6 did not reach nuget.org. A re-run of that release run uses the workflow of the tag, so the fix needs a new release.Related